electron
/
addon-tools-el
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

make getArrayData slice the bytes from the TypedArray's byte offset

This commit is contained in:
ptaylor 2019-08-09 01:54:38 -07:00
parent fc5a3a42b2
commit e7ac9f02c6
1 changed files with 11 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
include/addon-tools.hpp
View File

@ -267,23 +267,20 @@ inline Type* getArrayData(V8_VAR_OBJ obj, int *num = nullptr) {
Type *data = nullptr; Type *data = nullptr;
if (num) { if (obj->IsArrayBuffer()) {
*num = 0; v8::Local<v8::ArrayBuffer> ab = obj.As<v8::ArrayBuffer>();
} data = reinterpret_cast<Type*>(ab->GetContents().Data());
if (num) { *num = ab->ByteLength() / sizeof(Type); }
if ( ! obj->IsArrayBufferView() ) { } else if (obj->IsTypedArray()) {
v8::Local<v8::TypedArray> ta = obj.As<v8::TypedArray>();
data = static_cast<Type*>(ta->Buffer()->GetContents().Data()) + ta->ByteOffset();
if (num) { *num = ta->ByteLength() / sizeof(Type); }
} else {
if (num) { *num = 0; }
Nan::ThrowError("Argument must be a TypedArray."); Nan::ThrowError("Argument must be a TypedArray.");
return data;
} }
V8_VAR_ABV arr = V8_VAR_ABV::Cast(obj);
if (num) {
*num = arr->ByteLength() / sizeof(Type);
}
data = reinterpret_cast<Type*>(arr->Buffer()->GetContents().Data());
return data; return data;
} }