electron
/
addon-tools-el
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix deprecation warnings

This commit is contained in:
Luis Blanco 2018-11-29 11:33:36 +03:00
parent c4ab0d197c
commit cca0795e2d
2 changed files with 19 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
include/addon-tools.hpp
View File

@ -291,9 +291,14 @@ inline void *getData(V8_VAR_OBJ obj) {
inline void consoleLog(int argc, V8_VAR_VAL *argv) {
V8_VAR_STR code = JS_STR("((...args) => console.log(...args))");
V8_VAR_FUNC log = V8_VAR_FUNC::Cast(v8::Script::Compile(code)->Run());
Nan::Callback logCb(log);
v8::Local<v8::Value> log = v8::Script::Compile(
Nan::GetCurrentContext(), code
).ToLocalChecked()->Run(
Nan::GetCurrentContext()
).ToLocalChecked();
Nan::Callback logCb(Nan::To<v8::Function>(log).ToLocalChecked());
Nan::AsyncResource async("consoleLog()");
logCb.Call(argc, argv, &async);

20
include/event-emitter.hpp
View File

@ -333,13 +333,13 @@ private:
"(new Error()).stack.split('\\n').slice(2).join('\\n')"
);
V8_VAR_STR stack = Nan::To<v8::String>(
v8::Script::Compile(code)->Run(
v8::Local<v8::Value> stack = v8::Script::Compile(
Nan::GetCurrentContext(), code
).ToLocalChecked()->Run(
Nan::GetCurrentContext()
).ToLocalChecked()
);
).ToLocalChecked();
Nan::Utf8String stackStr(stack);
msg += *stackStr;
consoleLog(msg);
@ -441,13 +441,13 @@ private:
})
)");
V8_VAR_FUNC decor = Nan::To<v8::Function>(
v8::Script::Compile(code)->Run(
v8::Local<v8::Value> decor = v8::Script::Compile(
Nan::GetCurrentContext(), code
).ToLocalChecked()->Run(
Nan::GetCurrentContext()
).ToLocalChecked()
);
).ToLocalChecked();
Nan::Callback decorCb(Nan::To<v8::Function>(decor).ToLocalChecked());
Nan::Callback decorCb(decor);
V8_VAR_VAL argv[] = { info.This(), info[0], raw };
Nan::AsyncResource async("EventEmitter::js_once()");
V8_VAR_VAL wrapValue = decorCb.Call(3, argv, &async).ToLocalChecked();